Skip to content
Commit 95b8f0b6 authored by Yuanle Song's avatar Yuanle Song
Browse files

v0.100.1 code review for

- add error handling for all db operations
- refactoring to make it more readable.
  add doc for
  extract method copyDB(), initUserDB(), setPragmaOnMainDB()
- fix old timeoutCallback(), now named cb_saveUserDB()
  saveUserDB() should not be in the condition, because save can fail endlessly
  if file system have problem.
- no longer require main db to be a regular file. symlink should work fine.
- drop the dreaded overly reused class variable m_buffer. use meaningful names
  in current context.
- escape string in SQL statements
- update
  add prefix in PKGDATADIR
  define glib logging domain
  disable glib asserts for release build
- I will use so file version in git log.
parent 43004d6f
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment