Commit 78b258cb authored by Yuanle Song's avatar Yuanle Song
Browse files

v1.3.1 fix peppa-pig, peppa-pig-v theme on dark theme.

force label color to be black on these themes
parent c3d16d02
Loading
Loading
Loading
Loading
+4 −1
Original line number Diff line number Diff line
* COMMENT -*- mode: org -*-
#+Date: 2019-09-02
Time-stamp: <2020-06-03>
Time-stamp: <2023-08-01>

* zero-panel
zero-panel is a dbus service to provides a gtk3 based panel for showing
@@ -46,6 +46,9 @@ rsync and [[https://github.com/jordansissel/fpm][fpm]] is required.

* ChangeLog for zero-panel

- v1.3.1 2023-08-01
  - [fix] peppa-pig themes now support dark theme

- v1.3.0 2020-06-03
  - [feature] support multiple monitor setup.

+1 −1
Original line number Diff line number Diff line
# -*- mode: conf -*-
project('zero-panel', 'c',
  version: '1.3.0',
  version: '1.3.1',
  license: 'EPL-2.0',
  meson_version: '>=0.46.0',
  default_options: [
+90 −1
Original line number Diff line number Diff line
* COMMENT -*- mode: org -*-
#+Date: 2019-09-02
Time-stamp: <2022-08-29>
Time-stamp: <2023-08-01>
#+STARTUP: content
* notes                                                               :entry:
** 2020-06-03 how to make a release?
@@ -38,6 +38,19 @@ Time-stamp: <2022-08-29>
  cd build/
  G_MESSAGES_DEBUG=all ./zero-panel

** 2023-08-01 how to create themes?
- you need to create one ui file, one css file.
  make sure you have preedit_label, candidate_label, prev_page_label,
  next_page_label in your .ui file.

  it is easy to include image in your .ui file, see an example in
  ./themes/peppa-pig.ui

  see existing themes in ./themes/
- some color variables supported in gtk css
  @fg_color
  @bg_color

* later                                                               :entry:
** 2022-08-29 config zero-panel to always shown on-top in full screen mode window.
- when emacs run in full screen mode. (press f11 on my laptop) zero-panel
@@ -173,9 +186,85 @@ They don't work properly in Wayland.
** 
** 2019-09-02 support user configuration of theme and panel orientation.
is it supported by zero-el?
- 2023-08-01
  ~/.config/zero-panel.conf
  theme=default
  theme=zero-panel
  theme=peppa-pig-v
  horizontal
  vertical

- allow dynamic reload or change theme.
  is it easy to do?
  just quit, it will auto restart on next panel activation.

  add a cli command to quit zero-panel.
  in emacs I do
  (zero-input-panel-quit)

  just also support this in cli.
  zero-panel -k --kill      kill existing zero-panel and exit
  zero-panel -r --replace   kill existing zero-panel and start a new instance
  (--replace has a similar effect as reload)

** 2019-09-02 remove black bg in round corner. should be transparent.
is it because I don't have a compositor that support alpha?

- 2023-08-01 search: gtk border-radius round corner has dark background
  the problem is the compositor.
  you can try picom.
  what is KDE's compositor? kwin. kwin supports KDE round corners just fine.

* done                                                                :entry:
** 2023-08-01 support dark theme better.
when using dark theme, default font color is white, I can't read zero-panel
candidates.

- to support dark theme better
  - when using a picture as background, ignore theme font color, use my font
    color.

    ./themes/peppa-pig-v.ui
    ./themes/peppa-pig-v.css

  - when not using a picture as background, use gtk default.

- zero-panel default theme works fine in KDE dark theme.
  ./build/zero-panel
- peppa-pig-v theme not working properly.

  color: black;

  (zero-input-panel-quit)
  ./build/zero-panel -t peppa-pig-v

  nope. add color black didn't work. why?

  search: gtk text color in dark theme css

  try set some obvious css style, make sure it is effective.

  background-color: #000;
  it works.
- maybe in dark-theme, widget doesn't inherit bg color and color from parent.

  this didn't work:
  color: #000;
  background-color: #fff;

  what if I don't set bg color at all.
  bg is transparent.
  font color is white.

  for this color themed panel, font color should not follow system theme.

- try add style on label tag. it works.
  label works on any GtkLabel widget.

- some color variables supported in gtk css
  @fg_color
  @bg_color

** 2020-06-03 support dual monitor
- bug: 双显示器 zero-panel panel 没有显示到光标位置。而是在另一个屏幕右侧边缘。
  而且高度是对的。
+3 −0
Original line number Diff line number Diff line
@@ -9,6 +9,9 @@ window {
    background-color: #FFFFFF;
    border-radius: 20px;
}
label {
    color: black;
}
#preedit-label {
    margin: 5px;
}
+3 −0
Original line number Diff line number Diff line
@@ -14,6 +14,9 @@ window {
    min-width: 200px;
    min-height: 50px;
}
label {
    color: black;
}
#preedit-label {
    margin: 5px;
}